Added size option for EKRatingSymbolsContainerView #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
=========================================
- Coverage 1.60% 1.59% -0.01%
=========================================
Files 96 96
Lines 5544 5564 +20
=========================================
Hits 89 89
- Misses 5455 5475 +20
Continue to review full report at Codecov.
|
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals 🥅
Be able to set a custom size for the Rating Symbol Container View.
For example: if you want to show more than 5 stars in a row, now you can set the Rating Symbol Container View to 30 px (width and height).
Implementation Details ✏️
Just adding a size (CGSize) var in EKRatingItemContent and then updating the size in EKRatingSymbolsContainerView.